Ruby 3.3 Rails 7.2 sirenia rebase #6988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldp::Gone is the error raised by the fedora adapter when the resource is a tombstone after being deleted.
The valkyrie fedora adapter does not convert RDF Date causing comparison failures. In real use the embargo transaction converts to a datetime, but this factory sets the value directly, so let's make it match real use.
This fixes file_set_indexer_spec which has a bunch of odd setup and mocking, likely from before our factories were equipped to handle building work/file_set/file_metadata stacks. However, it feels right to include here and be treated as an ObjectNotFoundError.
- All 3 test apps use the same container image. - dassie stays in hyrax-webapp, koppie/sirenia live in hyrax-koppie. - db_migrate service moved to dev-entrypoint in web service. - Worker waits to start until rails app is up, should reduce bundle install racing. - hyrax-engine-dev target now based on hyrax-worker-base. - Chrome is still a pain and randomly stops responding.
Add worker to depends_on to avoid volume copy race. Fix Dockerfile style issues Align chrome service config Corrected container names for log capture
Now that this spec uses the real valkyrie adapter, the object coming out of wings is really an anonymous descendant of the valkyrie model class.
…pport::Dependencies#remove_constant
… handled correctly
…ler::Parameters, now deprecated
… default precision
# Conflicts: # .dassie/Gemfile # .koppie/Gemfile # spec/spec_helper.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.