Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies to support Ruby 3.3 and Rails 7.2 #6913

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Upgrade dependencies to support Ruby 3.3 and Rails 7.2 #6913

wants to merge 43 commits into from

Conversation

randalldfloyd
Copy link
Contributor

@randalldfloyd randalldfloyd commented Oct 2, 2024 •
edited
Loading

Fixes: #6905 , #6906

Summary

Contains numerous changes required to support Ruby 3.3 and Rails 7.2.
Okay to squash on merge (retain commit messages in message detail)

Detailed Description

Main areas of work

Dealing with constants and Rails 7 autoloader
Lots of issues with specs themselves due to incompatible usages of rspec, factories, etc.
Deprecated methods throughout the code
Upgrading/fixing compatibility with dependencies
Issues with strong parameter handling

Various misc. incompatibilities, see detailed commit message

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Test Results

    13 files  ±0      13 suites  ±0   2h 56m 47s ⏱️ - 1m 28s
 6 833 tests +1   6 534 ✅ +1  299 💤 ±0  0 ❌ ±0 
18 102 runs  +2  17 625 ✅ +2  477 💤 ±0  0 ❌ ±0 

Results for commit 665f810. ± Comparison against base commit 3c4a4b5.

This pull request removes 367 and adds 368 tests. Note that renamed tests count towards both. 
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f12b5be6a58>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f3bc6260c88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f442852cf88>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f12bbeaf658>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f3bc6a5c310>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f44280f7e40>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 175c8261-a1ed-43ff-9692-31a4b9fed28c
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 839aa930-2d90-41bd-892e-948e40122ee5
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: d75fc326-6597-40a3-b5c6-72db8e0129c2
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: c61f0978-f59a-48a8-899a-90f9053dc1c5
…

spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f15052d62e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f28dcea0018>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f4cf7ee16a0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f15036b7460>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f28dc40c318>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f4cf7f09d80>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: a83b495c-c25d-49a9-b2e7-5accbc85919e
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 37459bf2-11f5-4de8-85ec-f07f35a858fc
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7dd4fb16-ee7e-4819-a065-7e14da28cebd
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b1d55b42-a75d-4107-9fa1-9e590da3c946
…

♻️ This comment has been updated with latest results.

@cjcolvar cjcolvar force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from d2d1d8e to c54a552 Compare October 2, 2024 22:27
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 12 times, most recently from 9683dc6 to ad0ba7f Compare October 11, 2024 20:00
@randalldfloyd randalldfloyd force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from e95df99 to e6bf157 Compare October 15, 2024 20:17
randalldfloyd and others added 13 commits December 3, 2024 16:26
@cjcolvar cjcolvar force-pushed the ruby-3.3_rails-7.2 branch 2 times, most recently from eb34603 to ef66ca8 Compare December 11, 2024 16:19
Daniel Pierce and others added 14 commits January 21, 2025 12:04
Merge branch 'main' into ruby-3.3_rails-7.2
51636bf 
# Conflicts:
#	.dassie/Gemfile
#	.koppie/Gemfile
#	Dockerfile
#	spec/spec_helper.rb
@dlpierce
Update to Ruby 3.3 in Dockerfile
37ddc62
@dlpierce
Update to Alpine 3.21
d3986e6 
This required removing posix-spawn, reordering the docker user add, and disabling the native alpine packages.
@dlpierce
Refix db_config in spec_helper
89f3342
@randalldfloyd
Removing MiniMagick shell_api configuration because posix-spawn was r…
b29a850 
…emoved as Hyrax dependency
@dlpierce
view_paths is immutable in Rails 7.1
38fdbcb
@dlpierce
Must use to_formatted_s to pass a format now
e17c9dd
@dlpierce
Update spring_watcher_listen to allow newer spring
c943709
@randalldfloyd
Title needed when stubbing collection model in view specs for links t…
d9c6876 
…o render properly
@randalldfloyd
Temporarily reverting spring-watcher-listen to get test suite working…
b4ff5ea 
… again
@dlpierce
drop spring on the floor; remember to listen
7a90f3e
@dlpierce
expect our mock specifically
e1c8877
@randalldfloyd
Merge branch 'main' into ruby-3.3_rails-7.2
4e779ed
@randalldfloyd
Changing fcrepo image to 6.5.1 official release
665f810
@randalldfloyd randalldfloyd changed the title WIP: Support Ruby 3.3 and Rails 7.2 Upgrade dependencies to support Ruby 3.3 and Rails 7.2 Jan 24, 2025
@randalldfloyd randalldfloyd marked this pull request as ready for review January 24, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Rails 7.2 in Hyrax
3 participants
@randalldfloyd @cjcolvar @dlpierce