Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pitt account settings follow up - hide settings #2444

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Feb 4, 2025

Disable Pitt feature that sends user stats and emails, until these feature bugs get fixed:

:batch_email_notifications
:depositor_email_notifications
:user_analytics

The settings are no longer visible on the account form:

image

Shana Moore and others added 2 commits February 4, 2025 11:10
this commit disables the following from the account settings, until the GA4 feature bugs are fixed.

:batch_email_notifications
:depositor_email_notifciations
:user_analytics

this should've been done in this PR:
- https://github.com/samvera/hyku/pull/2429/files
Copy link
Collaborator

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that settings could be disabled so easily. This is great!

@laritakr laritakr added the patch-ver for release notes label Feb 4, 2025
@ShanaLMoore ShanaLMoore added ignore-for-release ignore this for release notes and removed patch-ver for release notes labels Feb 4, 2025
Copy link

github-actions bot commented Feb 4, 2025

Test Results

    3 files  ±0      3 suites  ±0   18m 0s ⏱️ -28s
2 059 tests ±0  2 003 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 086 runs  ±0  2 028 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit c5e8b29. ± Comparison against base commit b0de624.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e7496bd8-84cf-4cfa-a953-ab4a96cbce4d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 197e33f0-c345-4de5-bce4-d5430f6b30f4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 269d6cfd-7ead-4090-845c-b2524fd78662
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 932a7559-97bb-4735-8fd7-2329ad34f56e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy b6d3acf3-1254-4e2f-916f-f29d7cceca99
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a8086925-7788-425b-8791-82d6f70c324e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ac1d1835-fc97-4f29-9d85-07ece7551bb2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update d2ac3631-74fd-405a-a64e-cda26a1b5279
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 7724210a-ffe2-48a7-8034-372086da574d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 0c8c3b56-2c4f-48e6-8207-37f8c24f7fdb
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 22f9f9d0-fe54-4267-a320-2ee27a3ddfea
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit e9b8b563-213b-4b15-8523-7c755383ad32
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 6b41d290-0760-4e81-ad79-f533a64df584
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update cbea2b37-12d0-441c-a894-7cb27003e9e7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy e17086fb-d1af-47ee-8e04-48a7dfa8fd75
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 3296028d-daa1-4887-879c-cb12d1c02ede
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 012e8668-80ee-4891-9608-719ffb23ca17
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 68ddde10-2b6f-48e4-882c-d21cb8af39d4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy b716d613-1a02-4e4c-ab17-fe460144f88b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit d119b5f6-c9a9-4a14-9c31-df71a843f579
…

@ShanaLMoore ShanaLMoore merged commit 82b186e into main Feb 4, 2025
10 of 11 checks passed
@ShanaLMoore ShanaLMoore deleted the pitt-account-settings-follow-up branch February 4, 2025 20:18
@ShanaLMoore ShanaLMoore changed the title Pitt account settings follow up Pitt account settings follow up - hide settings Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants