-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pitt account settings follow up - hide settings #2444
Conversation
this commit disables the following from the account settings, until the GA4 feature bugs are fixed. :batch_email_notifications :depositor_email_notifciations :user_analytics this should've been done in this PR: - https://github.com/samvera/hyku/pull/2429/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that settings could be disabled so easily. This is great!
Test Results 3 files ±0 3 suites ±0 18m 0s ⏱️ -28s Results for commit c5e8b29. ± Comparison against base commit b0de624. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
Disable Pitt feature that sends user stats and emails, until these feature bugs get fixed:
:batch_email_notifications
:depositor_email_notifications
:user_analytics
The settings are no longer visible on the account form: