Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide PDF Resplit button #2443

Closed
wants to merge 1 commit into from
Closed

Hide PDF Resplit button #2443

wants to merge 1 commit into from

Conversation

laritakr
Copy link
Collaborator

@laritakr laritakr commented Feb 4, 2025

Summary

Refs:
notch8/palni_palci_knapsack#229 notch8/palni_palci_knapsack#80

Adds a new decorator to override the IiifPrint FileSetPresenterDecorator and prevent the resplit PDF button from appearing.

This is a temporary fix until we can get the resplit button to work by resolving issue notch8/palni_palci_knapsack#80

Details

The PDF resplit button is added in IiifPrint, and appears (via Hyku::TenantConfig) if the Tenant is set to use PDf Splitting. By adding a copy of IiifPrint's FileSetPresenterDecorator, we override this button to never appear.

Screenshot 2025-02-04 at 2 13 03 PM

Screenshot 2025-02-04 at 2 12 52 PM

Refs:
notch8/palni_palci_knapsack#229
notch8/palni_palci_knapsack#80

Adds a new decorator to override the IiifPrint FileSetPresenterDecorator
and prevent the resplit PDF button from appearing.

This is a temporary fix until we can get the resplit button to work.
@laritakr laritakr added the patch-ver for release notes label Feb 4, 2025
ShanaLMoore
ShanaLMoore previously approved these changes Feb 4, 2025
@ShanaLMoore ShanaLMoore dismissed their stale review February 4, 2025 19:53

revoking approval - turns out this is a larger issue and not just on resplit

Copy link

github-actions bot commented Feb 4, 2025

Test Results

    3 files  ±0      3 suites  ±0   17m 57s ⏱️ -31s
2 059 tests ±0  2 003 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 086 runs  ±0  2 028 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit b3e1011. ± Comparison against base commit b0de624.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy e7496bd8-84cf-4cfa-a953-ab4a96cbce4d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 197e33f0-c345-4de5-bce4-d5430f6b30f4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 269d6cfd-7ead-4090-845c-b2524fd78662
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 932a7559-97bb-4735-8fd7-2329ad34f56e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy b6d3acf3-1254-4e2f-916f-f29d7cceca99
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a8086925-7788-425b-8791-82d6f70c324e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ac1d1835-fc97-4f29-9d85-07ece7551bb2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update d2ac3631-74fd-405a-a64e-cda26a1b5279
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 7724210a-ffe2-48a7-8034-372086da574d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 0c8c3b56-2c4f-48e6-8207-37f8c24f7fdb
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy d4710596-0e1f-45fa-802c-36ff65d7b713
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit c3ac8d33-26c9-4620-8101-e348e400cde5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read a4299425-0160-45e3-b306-f0df61c133b8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update a5852e82-9dfb-404d-b0a4-c3592cf7d4b5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 4dc5d8c8-8d57-47ac-94fd-2566c9d2e3ca
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 58b64321-b863-462c-ae36-4f7eabda9ea6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 73d82b8f-c0a8-44de-8e93-4ff2fd255367
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e8d59b75-7036-4cd4-a7ff-e354c91c423c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 1b9afd26-c21c-4783-9982-4e136342e3c6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit b58d187f-5514-4360-b224-38d87d095994
…

@ShanaLMoore ShanaLMoore closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants