Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Remove Hyrax.config.analytics from the codebase #2437

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

kirkkwang
Copy link
Collaborator

We are now using Hyrax.config.analytics_reporting? instead. The analytics_button partial is deprecated and all references removed.

Ref:

We are now using Hyrax.config.analytics_reporting? instead.  The
analytics_button partial is deprecated and all references removed.

Ref:
- notch8/palni_palci_knapsack#177
@kirkkwang kirkkwang added the patch-ver for release notes label Jan 30, 2025
@ShanaLMoore ShanaLMoore requested a review from laritakr January 30, 2025 19:05
Copy link

Test Results

    3 files  ±0      3 suites  ±0   17m 32s ⏱️ -16s
2 057 tests ±0  2 001 ✅ ±0  56 💤 ±0  0 ❌ ±0 
2 084 runs  ±0  2 026 ✅ ±0  58 💤 ±0  0 ❌ ±0 

Results for commit 321c2b6. ± Comparison against base commit 0f7c56c.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy c7da57d7-937a-4ddd-9a23-208c22015e1b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 9046121f-0994-4c0b-bc60-91187a89c796
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 020914f8-d172-45e5-869b-779d1c50dffd
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 085f506c-70b8-46a9-aeb8-e59d3eb593cb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 3ffc6fbc-637e-4954-82cf-9978251ee508
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit ccb7a113-5dd3-48e2-8a14-019810bf2302
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 67708e2e-e5d5-4523-9462-3e98e26ea3c2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 889c8c0b-e96a-4d8f-b6d6-21c78cb8f520
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy b68ea7bd-8cde-45f0-951d-d1b305f3bbb4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 8ce0abfd-9674-4d61-86b9-cd07e7d519be
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy d3851e09-8da9-474c-8a29-946b6fb62da2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit dc2ed194-cdd1-4cf5-81c2-0f824a426206
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 6dd9b5cb-bb00-465b-b44b-9d66b7b35a24
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 8563f5f6-ece2-40a6-bea2-7e22b640737b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy fdbff809-b7a4-4a76-b3f0-dc7b29c919be
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit f1ad4827-2151-4277-831c-303c10da9752
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 67730925-ceee-44f6-b22e-9938d9d8d1ac
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 2898e55b-1e82-4fc4-b8b3-116ecba86ba6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 07ca6197-17db-4e35-8613-c1b1e43975f4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 99fea6b6-50f6-4a66-aed1-e38c76c24fd8
…

@kirkkwang kirkkwang merged commit 0f9c118 into main Jan 31, 2025
9 checks passed
@kirkkwang kirkkwang deleted the update-analytics-to-new-method branch January 31, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants