-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure there are UserStat records before running #2426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the noise
kirkkwang
previously approved these changes
Jan 22, 2025
Test Results 3 files + 1 3 suites +1 17m 30s ⏱️ + 5m 27s Results for commit 11c2741. ± Comparison against base commit 8b319ca. This pull request removes 42 and adds 554 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
kirkkwang
reviewed
Jan 22, 2025
07c1ac8
to
72c5ab1
Compare
ShanaLMoore
commented
Jan 22, 2025
- Added spec contexts to test behavior when UserStat records are present and absent. - Defined a FactoryBot factory for UserStat to support spec setup.
488a362
to
11c2741
Compare
kirkkwang
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidekiq is flooded with UserStatCollectionJob even when UserStats.any? => false.
Let's not run the job if there are no user stats