🐛 Fix rerun for entries that came from zips #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanaLMoore
reviewed
Jan 28, 2025
kirkkwang
force-pushed
the
fix-rerun-for-entries-that-came-from-zips
branch
2 times, most recently
from
32083d9 to
95294d9
Compare
Previously, when rerunning an entry that came from a zip file, the rerun would fail because it would look for the CSV in an assumed location which is based on it's last importer ID. Since this was a rerun, it does not do an unzip into the assumed location so the directory does not exist. This commit will first check if the assumed location exists, and if not, it will look for the location of the last unizpped files and use that for the rerun. Ref: - notch8/palni_palci_knapsack#210
kirkkwang
force-pushed
the
fix-rerun-for-entries-that-came-from-zips
branch
from
95294d9 to
2826999
Compare
ShanaLMoore
approved these changes
Jan 29, 2025
kirkkwang
added a commit
to samvera/hyku
that referenced
this pull request
Jan 29, 2025
This commit will bring in a fix for reruning Bulkrax entries Ref: - samvera/bulkrax#1013 - notch8/palni_palci_knapsack#210
kirkkwang
added a commit
to notch8/palni_palci_knapsack
that referenced
this pull request
Jan 29, 2025
This commit will update the Hyku submodule to bring in the latest fix for a Bulkrax bug for rerunning entries from zips. Ref: - samvera/bulkrax#1013 - #210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when rerunning an entry that came from a zip file, the rerun would fail because it would look for the CSV in an assumed location which is based on it's last importer ID. Since this was a rerun, it does not do an unzip into the assumed location so the directory does not exist.
This commit will first check if the assumed location exists, and if not, it will look for the location of the last unizpped files and use that for the rerun.
Ref: