Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Cleaning up UI on importers show #1011

Merged
merged 3 commits into from
Jan 23, 2025
Merged

🐛 Cleaning up UI on importers show #1011

merged 3 commits into from
Jan 23, 2025

Conversation

kirkkwang
Copy link
Contributor

@kirkkwang kirkkwang commented Jan 23, 2025

🐛 Cleaning up UI on importers show

4fb1a9a

This commit will align the download buttons on the importer pages with
the header. Also, the table width was funky so that is also fixed.

Before:

Zight.Recording.2025-01-23.at.10.15.21.mp4

After:

Zight.Recording.2025-01-23.at.10.22.29.mp4

Add missing translations

786fb46

This commit will add missing translations for the importer show page
table.

image

Hide importer-entry-classes div

8ff8d77

In Bootstrap 4 we now use d-none.

image

@kirkkwang kirkkwang added the patch-ver for release notes label Jan 23, 2025
@kirkkwang kirkkwang force-pushed the add-responsive-table branch from 811fdb5 to 782ed12 Compare January 23, 2025 18:57
This commit will align the download buttons on the importer pages with
the header.  Also, the table width was funky so that is also fixed.
This commit will add missing translations for the importer show page
table.
In Bootstrap 4 we now use d-none.
@kirkkwang kirkkwang force-pushed the add-responsive-table branch from 782ed12 to 8ff8d77 Compare January 23, 2025 20:17
@kirkkwang kirkkwang merged commit 0e8de61 into main Jan 23, 2025
6 checks passed
@kirkkwang kirkkwang deleted the add-responsive-table branch January 23, 2025 21:22
kirkkwang added a commit to samvera/hyku that referenced this pull request Jan 23, 2025
This commit will bring in view changes from Bulkrax for the importer
show page.

Ref:
- samvera/bulkrax#1011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants