call the cops

samvera · Jan 16, 2024 · a762f14 · a762f14
1 parent 1503cda
commit a762f14
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/app/controllers/bulkrax/entries_controller.rb b/app/controllers/bulkrax/entries_controller.rb
@@ -50,6 +50,7 @@ def destroy
     end
 
     protected
+
     # GET /importers/1/entries/1
     def show_importer
       @importer = Importer.find(params[:importer_id])

diff --git a/app/controllers/bulkrax/importers_controller.rb b/app/controllers/bulkrax/importers_controller.rb
@@ -309,8 +309,8 @@ def update_harvest
     def set_files_parser_fields
       @importer.parser_fields['update_files'] =
         @importer.parser_fields['replace_files'] =
-        @importer.parser_fields['remove_and_rerun'] =
-        @importer.parser_fields['metadata_only'] = false
+          @importer.parser_fields['remove_and_rerun'] =
+            @importer.parser_fields['metadata_only'] = false
       if params[:commit] == 'Update Metadata and Files'
         @importer.parser_fields['update_files'] = true
       elsif params[:commit] == ('Update and Replace Files' || 'Update and Re-Harvest All Items')

diff --git a/app/helpers/bulkrax/application_helper.rb b/app/helpers/bulkrax/application_helper.rb
@@ -2,10 +2,10 @@
 module Bulkrax
   module ApplicationHelper
     def item_entry_path(item, e, opts = {})
-      is_an_importer?(item) ? bulkrax.importer_entry_path(item.id, e.id, opts) : bulkrax.exporter_entry_path(item.id, e.id, opts)
+      an_importer?(item) ? bulkrax.importer_entry_path(item.id, e.id, opts) : bulkrax.exporter_entry_path(item.id, e.id, opts)
     end
 
-    def is_an_importer?(item)
+    def an_importer?(item)
       item.class.to_s.include?('Importer')
     end
 

diff --git a/app/models/bulkrax/importer.rb b/app/models/bulkrax/importer.rb
@@ -3,7 +3,7 @@
 require 'iso8601'
 
 module Bulkrax
-  class Importer < ApplicationRecord
+  class Importer < ApplicationRecord # rubocop:disable Metrics/ClassLength
     include Bulkrax::ImporterExporterBehavior
     include Bulkrax::StatusInfo
 

diff --git a/app/views/bulkrax/shared/_entries_tab.html.erb b/app/views/bulkrax/shared/_entries_tab.html.erb
@@ -30,7 +30,7 @@
           <td><%= e.status_at %></td>
           <td>
             <%= link_to raw('<span class="glyphicon glyphicon-info-sign"></span>'), item_entry_path(item, e) %>
-            <% if is_an_importer?(item) %>
+            <% if an_importer?(item) %>
               <a class="glyphicon glyphicon-refresh" data-toggle="modal" data-target="#bulkraxItemModal" data-entry-id="<%= e.id %>"></a>
             <% end %>
             <%= link_to raw('<span class="glyphicon glyphicon-trash"></span>'), item_entry_path(item, e), method: :delete, data: { confirm: 'This will delete the entry and any work associated with it. Are you sure?' } %>