Merge pull request #453 from samvera-labs/remove-empty-id-when-settin…

…g-object-attrs

remove-empty-id-when-setting-object-attrs

app/factories/bulkrax/object_factory.rb

@@ -137,6 +137,7 @@ def work_actor
     end
 
     def create_collection(attrs)
+      attrs = clean_attrs(attrs)
       attrs = collection_type(attrs)
       persist_collection_memberships(parent: find_collection(attributes[related_parents_parsed_mapping]), child: object) if attributes[related_parents_parsed_mapping].present?
       object.attributes = attrs
@@ -154,6 +155,7 @@ def update_collection(attrs)
     def create_file_set(attrs)
       work = find_record(attributes[related_parents_parsed_mapping].first)
       work_permissions = work.permissions.map(&:to_hash)
+      attrs = clean_attrs(attrs)
       file_set_attrs = attrs.slice(*object.attributes.keys)
       object.assign_attributes(file_set_attrs)
 
@@ -202,8 +204,16 @@ def find_collection(id)
       end
     end
 
+    def clean_attrs(attrs)
+      # avoid the "ArgumentError: Identifier must be a string of size > 0 in order to be treeified" error
+      # when setting object.attributes
+      attrs.delete('id') if attrs['id'].blank?
+      attrs
+    end
+
     def collection_type(attrs)
       return attrs if attrs['collection_type_gid'].present?
+
       attrs['collection_type_gid'] = Hyrax::CollectionType.find_or_create_default_collection_type.gid
       attrs
     end

spec/jobs/bulkrax/importer_job_spec.rb

@@ -5,6 +5,9 @@
 module Bulkrax
   RSpec.describe ImporterJob, type: :job do
     subject(:importer_job) { described_class.new }
+    # the bulkrax_importer_oai base_url comes from a live website
+    # until it is stubbed, the values below will fluctuate as the api changes
+    # TODO(alishaevn): delete the above comments when issue 455 is complete
     let(:importer) { FactoryBot.create(:bulkrax_importer_oai) }
 
     before do