-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install template for quicker installation #2782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message so there is no [WIP]
messages. Would you mind squashing into one commit too?
@jcoyne oops, yes. doing too many things and didn't push my change. |
cc52ee4
to
461a2e1
Compare
Looks like rails_command is only available in rails 5 and not in 4.2: http://guides.rubyonrails.org/v4.2/rails_application_templates.html Other commands look good though. |
Working on it. Thanks, @elo2112! |
461a2e1
to
c326563
Compare
New changes look good, but I wanted to test the template to be sure. Encountered something strange. This works (latest Rails 4 release):
But this gives me some issues (latest Rails 5 release):
The command above with Rails 5 ends up creating a massive number of processes on my computer: $ ps ux | wc -l (My baseline before running the command was around 160 processes.) So many, in fact, that I can't create new ones: $ ps ux | wc -l And I start seeing tons of repeating messages like this in my console:
That said, the template does eventually finish running. This is on Mac OS 10.11.6 with Ruby 2.3. The process count was much lower in the Rails 4 test, by several hundred. Is anyone else experiencing anything similar? |
@elo2112 I think you're running into this issue with listen/rails: rails/rails#26158 |
@elo2112 Ha, @cgalarza ran into the same yesterday, and I added this to the Sufia Dev Guide: https://github.com/projecthydra/sufia/wiki/Sufia-Development-Guide#install-problems I'm hesitant to amend the README to suggest using |
@mjgiarlo Ah! Just caught up on yesterday's Slack chat and I see what you're referring to, thanks. All good with --skip-listen. PR looks good to me. |
Using a template, and updating it within every release, allows us to simplify the instructions for developers who wish to get Sufia up and running in development mode very quickly. Also helps automate manual steps such as the inclusion of the
flipflop
gem from GitHub.README and release management process have already been updated to reflect the new template.