support structs with optional fields with num > 64

samuel · Aug 25, 2016 · 4e55701 · 4e55701
1 parent edbcd25
commit 4e55701
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/parser/types.go b/parser/types.go
@@ -23,7 +23,7 @@ type Typedef struct {
 type EnumValue struct {
 	Name        string
 	Value       int
-	Set   bool
+	Set         bool
 	Annotations []*Annotation
 }
 

diff --git a/thrift/thrift.go b/thrift/thrift.go
@@ -252,14 +252,15 @@ func encodeFields(t reflect.Type) structMeta {
 				continue
 			}
 			id, opts := parseTag(tv)
-			if id >= 64 {
-				// TODO: figure out a better way to deal with this
-				panic("thrift: field id must be < 64")
-			}
 			ef.id = id
 			ef.name = f.Name
 			ef.required = opts.Contains("required")
 			if ef.required {
+				if id >= 64 {
+					// TODO: figure out a better way to deal with this
+					panic("thrift: field id must be < 64")
+				}
+
 				m.required |= 1 << byte(id)
 			}
 			ef.keepEmpty = opts.Contains("keepempty")