Add support for enums in top level #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially address samscott89#71
|
I came looking to see if someone had already fixed this and found this PR. @samscott89, any plans to merge this or does it need more work? |
|
Hey @jesterpm! I'm just getting back into maintaining this crate after an extended period of low maintenance. I'm planning on including this in a 1.0 release. If this is blocking you on something though I can try and get this in sooner in a 0.x release? |
|
Well, that's serendipitous. No rush, I can use a fork until 1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #71
I am not sure this is the best way to do it, whether it will impact currently untested scenarios, or slow down deserialisation heavily. So I'm open to any suggestion.