Skip to content

Commit

Permalink
Address Jans comments
Browse files Browse the repository at this point in the history
  • Loading branch information
timakro committed Dec 19, 2024
1 parent d438c31 commit 36ae636
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ services:
# Optional GitLab parameters
# The base URL for API calls, e.g. "https://gitlab.com/"
- GITLAB_URL=https://gitlab.com/
- GITLAB_URL=
# A long-living personal (or impersonation) access token that is used to create short-living project access tokens. Requires at least the "api" scope. Note that group access tokens and project access tokens cannot be used to create project access tokens.
- GITLAB_API_ACCESS_TOKEN=
```
Expand Down
2 changes: 1 addition & 1 deletion central/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ serde_json = "1"
rand = "0.8"
reqwest = { version = "0.12", default_features = false, features = ["default-tls"] }
urlencoding = "2.1.3"
chrono = { version = "0.4.39", features = ["serde"] }
chrono = "0.4.39"
2 changes: 1 addition & 1 deletion central/src/gitlab.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ impl GitLabProjectAccessTokenProvider {
"HTTP status error {} for url {} with body {}",
response.status(),
response.url().clone(),
response.text().await.unwrap()
response.text().await.map_err(|e| e.to_string())?
))
}
}
Expand Down
1 change: 1 addition & 0 deletions deny.toml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ allow = [
"BSD-3-Clause",
"Unicode-DFS-2016",
#"Apache-2.0 WITH LLVM-exception",
"Unicode-3.0",
]
# List of explicitly disallowed licenses
# See https://spdx.org/licenses/ for list of possible licenses
Expand Down
4 changes: 2 additions & 2 deletions dev-gitlab/docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ services:
- BEAM_URL=http://proxy:8082
- BEAM_ID=app2.proxy2.broker
- BEAM_SECRET=App1Secret
- GITLAB_URL=https://git.verbis.dkfz.de/
- GITLAB_API_ACCESS_TOKEN=YjTXxdzLMak-XXscyxy4
- GITLAB_URL=
- GITLAB_API_ACCESS_TOKEN=
extra_hosts:
# Containers can access the host at 172.17.0.1
- "proxy:172.17.0.1"
Expand Down

0 comments on commit 36ae636

Please sign in to comment.