Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indicate sorting in table headers using arrows #190

Merged
merged 2 commits into from
Feb 4, 2025
Merged

fix: indicate sorting in table headers using arrows #190

merged 2 commits into from
Feb 4, 2025

Conversation

timakro
Copy link
Contributor

@timakro timakro commented Feb 3, 2025

Fixes #185

@timakro
Copy link
Contributor Author

timakro commented Feb 3, 2025

image

patrickskowronekdkfz
patrickskowronekdkfz requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@patrickskowronekdkfz patrickskowronekdkfz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the that now both ways to sort works, some small issues are there still

packages/lib/src/components/results/ResultTableComponent.wc.svelte Outdated Show resolved Hide resolved
packages/lib/src/components/results/ResultTableComponent.wc.svelte Show resolved Hide resolved
@patrickskowronekdkfz patrickskowronekdkfz merged commit 90b9540 into develop Feb 4, 2025
6 checks passed
@patrickskowronekdkfz patrickskowronekdkfz deleted the fix/show-sorting-in-table-headers branch February 4, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickskowronekdkfz patrickskowronekdkfz patrickskowronekdkfz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Result table sorting partially implemented
2 participants
@timakro @patrickskowronekdkfz