[feat] SP config should decide validation of signature #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some SP required to do sign SAML response message it self. Follow the origin coding style Signed message opts signed was the instance method
Small test for Entity ID
This reverts commit 1d859c1.
ID should be same for sign and document
verify signature Fixes
…age" This reverts commit cba7e02.
Install bundle for RVM version Exclude build with issue because, can't check rails version before install it.
Update library for cloud SAML services.
Small test for Entity ID Name space should be defined
…required [bug] Keyinfo is not required
[feat] External Signature Algorithm (Redirect Binding)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SP config
validate_signatureis not utilized, and each SP config can decide whether to force signature validation or not.