[WIP] Configure IdP and SP with configuration object #183

Zogoo · 2022-07-13T23:58:54Z

The idea of this PR is that Gem should not care about how to store metadata. Because too much involving developer decisions makes this gem harder to maintain.
#71

Let's drop persistance of metadata and how to refresh it because those implementation could be done with another gem (top of this gem) for different web frameworks. Or even it could be done by developers If we just accept "SamlIdp::IncomingMetadata" (IMO this should be also renamed) for all configuration of IdP.

#71

jphenow · 2022-07-14T16:08:34Z

Makes sense I think. Can much of the same be accomplished without the config? Might be good to document.

Would definitely say this is a change of API to the point that it might be good to place this in a new major version - in which case if we wanted to make a lot of breaking changes, might be good to figure out if we want a branch for vnext and maintain master for bugs until vnext is ready or how to go about managing the branches there.

…or this reason dropping SP metadata logic. Because IdP project can decide how to provide metadata.

… extra options.

Zogoo · 2024-01-08T15:07:10Z

@jphenow, @mjobin-mdsol I have almost finished the required code changes and started working on test cases. Could you guys please do a quick review to confirm the changes are okay?

The main change is that the IdpConfig and SpConfig objects allow to configure of the IdP for specific service providers. And it's not a global config because this allows 2 things

Gem users can use it for multiple SPs. This means SP config can be different for different SPs. Like X509 certificate, NameIDFormat etc.
Gem users can make decisions about how they want to manage configs like DB, Global Object, Redis etc.

jphenow · 2024-01-08T16:36:19Z

README.md

+This was originally setup by @lawrencepit to test SAML Clients. I took it closer to a real SAML IDP implementation.
+Forked from <https://github.com/lawrencepit/ruby-saml-idp>


Suggested change

This was originally setup by @lawrencepit to test SAML Clients. I took it closer to a real SAML IDP implementation.

Forked from <https://github.com/lawrencepit/ruby-saml-idp>

This was originally a fork of @lawrencepit's project <https://github.com/lawrencepit/ruby-saml-idp> which was for testing SAML Clients.

This project implements an actual SAML IdP.

jphenow · 2024-01-08T16:37:11Z

README.md


-Be sure to load a file like this during your app initialization:
+2. SP data such 


Suggested change

2. SP data such

2. ServiceProvider configuration

jphenow · 2024-01-08T16:37:56Z

README.md

+  config.signed_assertion = false                               # Default: true which means signed assertions on the SAML Response
+  config.compress = true                                        # Default: false which means the SAML Response is not being compressed
+
+  Principal (e.g. User) is passed in when you `encode_response`


Suggested change

Principal (e.g. User) is passed in when you `encode_response`

# Principal (e.g. User) is passed in when you `encode_response`

jphenow · 2024-01-08T16:38:45Z

README.md

+  If you have a method called `asserted_attributes` in your Principal class,
+  there is no need to define it here in the config.


Suggested change

If you have a method called `asserted_attributes` in your Principal class,

there is no need to define it here in the config.

# If you have a method called `asserted_attributes` in your Principal class,

# there is no need to define it here in the config.

jphenow · 2024-01-08T16:39:11Z

README.md

+  If you have a method called `asserted_attributes` in your Principal class,
+  there is no need to define it here in the config.
+
+  config.saml_attributes  =>


is this showing what saml_attributes returns? I'm confused by the => here

Oh, I forgot to mention that I haven't work documents yet. Once I finish code, I will update all documents.

jphenow · 2024-01-08T16:40:04Z

README.md

-  #       persistent: -> (p) { p.id },
-  #     },
-  #   }
+  configure_sp do |config|


maybe spell out service_provider instead of sp? Abbreviations get confusing IMO.

where is this defined? I'm having trouble following how this gets configured/used.

jphenow · 2024-01-08T16:49:04Z

README.md

@@ -229,13 +202,13 @@ The second parameter is optional and default to your configuration `SamlIdp.conf
 To act as a Service Provider which generates SAML Requests and can react to SAML Responses use the
 excellent [ruby-saml](https://github.com/onelogin/ruby-saml) gem.

-## Author
+# Author


Let's just remove the author section.

mjobin-mdsol

I glanced at it, but I am sorry I don't have useful comments at the moment.

Zogoo · 2024-10-24T22:28:41Z

This was too big PR for the current gem, I will create small PRs that allow transfer slowly to v2

No need to persist metadata

c087bbb

#71

Zogoo added the enhancement label Jul 13, 2022

Zogoo self-assigned this Jul 13, 2022

Cleanup

1226378

Zogoo changed the title ~~No need to persist metadata~~ [WIP] No need to persist metadata Jul 15, 2022

zogoo added 2 commits July 15, 2022 20:23

Dropping persister logic

93767c3

WIP, Since gem main logic is generating saml request and responses. F…

f2b62ac

…or this reason dropping SP metadata logic. Because IdP project can decide how to provide metadata.

Zogoo closed this Jul 16, 2022

Zogoo reopened this Jul 16, 2022

Zogoo changed the title ~~[WIP] No need to persist metadata~~ [WIP] Support only object for SP provider and SP metadata, Drop metadata file loader, persister methdos Jul 16, 2022

Zogoo changed the title ~~[WIP] Support only object for SP provider and SP metadata, Drop metadata file loader, persister methdos~~ [WIP] Support only object for SP provider and SP metadata, Drop metadata file loader, persister methods Jul 16, 2022

Zogoo marked this pull request as draft July 16, 2022 07:23

Merge branch 'master' into feature/simplify_gem

9fb38ca

Zogoo changed the base branch from master to v0.2.0-saml-lib January 3, 2024 18:16

Initiate IdP on demand

43a9b2d

Zogoo force-pushed the feature/simplify_gem branch from 7e85449 to 43a9b2d Compare January 3, 2024 20:00

[ci skip] Split SP and IdP configs

5021c34

Zogoo force-pushed the feature/simplify_gem branch from f4dc78e to 5021c34 Compare January 3, 2024 22:19

Zogoo added the breaking-change Changes should be treated with major version label Jan 4, 2024

Zogoo added this to the Simplify gem for SAML milestone Jan 4, 2024

Zogoo force-pushed the feature/simplify_gem branch 4 times, most recently from d8ca283 to 220ba26 Compare January 4, 2024 23:18

[ci skip] IdP Config will initialize for each requests no need to use…

5fa6eba

… extra options.

Zogoo force-pushed the feature/simplify_gem branch from 220ba26 to 5fa6eba Compare January 5, 2024 00:24

Zogoo changed the title ~~[WIP] Support only object for SP provider and SP metadata, Drop metadata file loader, persister methods~~ [WIP] Configure IdP and SP with configuration object Jan 5, 2024

zogoo added 2 commits January 7, 2024 13:43

[ci skip] Certificate from IdP config

348feb3

Extract out XML namespace and document

ef3e0b4

[ci skip] Align SP config with SP metadata

d14ae6f

Zogoo force-pushed the feature/simplify_gem branch 2 times, most recently from c0a54c0 to d4b376d Compare January 7, 2024 19:14

[ci skip] WIP - Controller SPEC

0ed50c6

Zogoo force-pushed the feature/simplify_gem branch from d4b376d to 0ed50c6 Compare January 7, 2024 23:44

Zogoo requested review from jphenow and mjobin-mdsol January 8, 2024 15:07

jphenow reviewed Jan 8, 2024

View reviewed changes

mjobin-mdsol reviewed Jan 10, 2024

View reviewed changes

Zogoo closed this Oct 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Configure IdP and SP with configuration object #183

[WIP] Configure IdP and SP with configuration object #183

Zogoo commented Jul 13, 2022

jphenow commented Jul 14, 2022

Zogoo commented Jan 8, 2024 •

edited

Loading

jphenow Jan 8, 2024

jphenow Jan 8, 2024

jphenow Jan 8, 2024

jphenow Jan 8, 2024

jphenow Jan 8, 2024

Zogoo Jan 9, 2024

jphenow Jan 8, 2024

jphenow Jan 8, 2024

jphenow Jan 8, 2024

mjobin-mdsol left a comment

Zogoo commented Oct 24, 2024

		This was originally setup by @lawrencepit to test SAML Clients. I took it closer to a real SAML IDP implementation.
		Forked from <https://github.com/lawrencepit/ruby-saml-idp>


		Be sure to load a file like this during your app initialization:
		2. SP data such

	Principal (e.g. User) is passed in when you `encode_response`
	# Principal (e.g. User) is passed in when you `encode_response`

		If you have a method called `asserted_attributes` in your Principal class,
		there is no need to define it here in the config.

[WIP] Configure IdP and SP with configuration object #183

[WIP] Configure IdP and SP with configuration object #183

Conversation

Zogoo commented Jul 13, 2022

jphenow commented Jul 14, 2022

Zogoo commented Jan 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjobin-mdsol left a comment

Choose a reason for hiding this comment

Zogoo commented Oct 24, 2024

Zogoo commented Jan 8, 2024 •

edited

Loading