remove md5 source hash prepend

[blbradley]

Modern versions of Salt match hash length to hash type.

I was the author of this piece of code.

[sroegner]

@blbradley just a random thought: it certainly is beneficial to keep the hash type for users of older salt versions - is keeping it detrimental in any way when using newer Salt versions?

[blbradley]

Yes, although I'm out of touch with the error thrown.

With this patch, the user will choose either a value or a key=value that is compatible with their version of Salt. In addition, I'm pretty sure this patch will not break anything for end users of older versions.

[blbradley]

Clarification: older versions of this formula or older versions of Salt.

Let me know if you need the error/reports/runs on an older version of Salt.

[blbradley]

I finally setup a single machine HDFS minion and ran my states without this patch:

          ID: unpack-hadoop-dist
    Function: archive.extracted
        Name: /usr/lib/
      Result: False
     Comment: Invalid length (64) for hash type 'md5'. Either remove the hash type and simply use 'd489df3808244b906eb38f4d081ba49e50c46
03db03efd5e594a1e98b09259c2' as the source_hash, or change the hash type to 'sha256'
     Started: 12:42:12.242848
    Duration: 1.238 ms
     Changes:
----------

So, users cannot use hash types other than md5 without this patch.

[blbradley]

This will not restrict users of older versions of Salt. They would now be required to supply the hash type and the hash instead of just the md5 hash.

[blbradley]

Been almost a year. I don't remember the context. Is this better or worse?