Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if we can just remove libeay32 download #11

Closed

Conversation

lkubb
Copy link
Member

@lkubb lkubb commented Nov 3, 2024

What does this PR do?

What issues does this PR fix or reference?

Fixes:

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.50%. Comparing base (74477e3) to head (4dcb75a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   64.50%   64.50%           
=======================================
  Files          31       31           
  Lines        4575     4575           
  Branches      701      701           
=======================================
  Hits         2951     2951           
  Misses       1453     1453           
  Partials      171      171           
Flag Coverage Δ
Linux 64.37% <ø> (ø)
macOS 48.65% <ø> (-0.03%) ⬇️
project 56.00% <ø> (ø)
py310 64.41% <ø> (ø)
py38 64.31% <ø> (ø)
py39 64.39% <ø> (ø)
salt_3006_9 64.43% <ø> (ø)
salt_3007_1 64.41% <ø> (ø)
tests 72.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkubb
Copy link
Member Author

lkubb commented Nov 3, 2024

It seems nothing basic is preventing the removal.

@lkubb lkubb closed this Nov 3, 2024
@lkubb lkubb deleted the testing/workflows-remove-libeay32 branch November 3, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant