[DEVOPS-158] Implement required value(s) #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yusufhm do we need to update the documentation too? |
sonnykt
approved these changes
Feb 3, 2025
steveworley
approved these changes
Feb 3, 2025
MarkCalvert
reviewed
Feb 4, 2025
MarkCalvert
reviewed
Feb 4, 2025
- Bubble up exit error. - Return correct value in error when plugin is unsupported. - Prevent duplicate error messages when input fact collection fails. - Add error logging when docker command fails.
- Started a guide on connections. - Added a connection example. - Added stub pages for other sections. - Added a file for analyse common fields. - Started adding some details for `allowed:list`.
|
I've added some basic doco & stubs for some other pages so we can start having a structure around them. Since it's a bigger task than this PR, will just leave it at that for now and we can add more later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allowed:listplugin.Basically
examples/required-values.yml&examples/single-value-regex-match.ymlare doing the same checks, although the former allows having a list of values and comparing against a list, while the latter only compares against a string. Depending on the use case, one of the other could be useful.