[DEVOPS-616] Added systemWide flag support to task_definition. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnykt
force-pushed
the
feature/DEVOPS-616_task_definition_systemwide
branch
2 times, most recently
from
5dd4d0c to
9d4f30b
Compare
yusufhm
reviewed
Oct 10, 2024
There was a problem hiding this comment.
I believe this file should not be required anymore since we're now using the mutation builder instead, but I did not remove it yet due to not having proper tests for the new dynamic system, so maybe we can leave this in until the tests are done.
yusufhm
approved these changes
Oct 11, 2024
sonnykt
force-pushed
the
feature/DEVOPS-616_task_definition_systemwide
branch
from
9d4f30b to
9f4896e
Compare
|
Hey @sonnykt — are you able to resolve the mere conflict? |
|
@steveworley the merge conflict has been resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.