Feature/update deploytargetconfig task #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashed-k
requested review from
steveworley and
yusufhm
and removed request for
yusufhm and
steveworley
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously, any update in config related to weight, pull-request and deploytarget ID, the id was deleted and then recreated as a update process for deploy target config. However, this wasn't the case for any updated branch in config which added new deploy target config but did not delete the previous deploy target config IDs.
I have now added additional logic for
deletion_requiredwhich checks if there is any branch from existing config that does not match the desired config should be in deletion_required.Also, the unit testing file for deploytargetconfig is updated.