fix: bubble up TransportQueryError

salsadigitalauorg · Jul 19, 2024 · 6a45c83 · 6a45c83
1 parent d6de050
commit 6a45c83
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/api/plugins/action/fact.py b/api/plugins/action/fact.py
@@ -25,11 +25,11 @@ def get_facts(client: GqlClient, environment_id):
     )
 
     try:
+        if "error" in res:
+            return res
         return res["environmentById"]["facts"]
     except KeyError:
         return dict()
-    except:
-        raise
 
 
 def delete_fact(client: GqlClient, environment_id, name):
@@ -136,6 +136,9 @@ def run(self, tmp=None, task_vars=None):
         found_fact = False
 
         facts = get_facts(self.client, environment_id)
+        if "error" in facts:
+            raise facts["error"]
+
         for fact in facts:
             if fact["name"] == name:
                 found_fact = fact

diff --git a/api/plugins/module_utils/gql.py b/api/plugins/module_utils/gql.py
@@ -70,7 +70,8 @@ def execute_query(self, query: str, variables: Optional[Dict[str, Any]]={}) -> D
             self.vvvv(f"GraphQL query result: {res}")
             return res
         except TransportQueryError as e:
-            return e
+            self.vvvv(f"GraphQL TransportQueryError: {e}")
+            return {'error': e}
 
     def build_dynamic_query(self, query: str, mainType: str, args: Optional[Dict[str, Any]] = {}, fields: List[str] = [], subFieldsMap: Optional[Dict[str, List[str]]] = {}) -> DSLField:
         """