feature: Add support for dumping database contents #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in this HackMD, we want to dump the contents of a Salsa database in order to debug what rust-analyzer and Salsa are doing. The original Salsa had a
DebugQueryTable
that we'd use like this:(
ParseQuery
andParseMacroExpansionQuery
were generated fromSourceDatabase::parse
andExpandDatabase::parse_macro_expansion
, respectively.)This PR takes a slightly different approach: instead of generating a
Query
struct corresponding to a tracked function or Salsa struct, this PR simply exposes the underlying pages onsalsa::Storage
via thedebug_input_entries
,debug_input_entries
, anddebug_interned_entries
methods. This results in the following API:Few notes:
{interned, tracked, input}::Value
publicly, which feels suboptimal, but we're all friends here, right?