-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows #11
base: master
Are you sure you want to change the base?
Windows #11
Conversation
Thanks for the contribution! Unfortunately we can't verify the commit author(s): matthewscott <m***@h***.c***.au>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatthewJuliusScott can you separate the formatting changes from the windows 10 changes? Currently, it is hard to tell which changes are important.
<properties> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding> | ||
<java-version>16</java-version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot move to JDK 16 because other systems/applications use this code and are not compatible. Please keep this as JDK 11.
Thanks for the contribution! Before we can merge this, we need @MatthewJuliusScott to sign the Salesforce.com Contributor License Agreement. |
No description provided.