sync from external: fix source and distinguish errors

saketh-are · Nov 21, 2024 · be5637b · be5637b
1 parent 955d846
commit be5637b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/chain/client/src/sync/state/external.rs b/chain/client/src/sync/state/external.rs
@@ -46,12 +46,13 @@ impl StateSyncDownloadSourceExternal {
                 Err(near_chain::Error::Other("Timeout".to_owned()))
             }
             _ = cancellation.cancelled() => {
-                increment_download_count(shard_id, typ, "external", "error");
+                increment_download_count(shard_id, typ, "external", "cancelled");
                 Err(near_chain::Error::Other("Cancelled".to_owned()))
             }
             result = fut => {
                 result.map_err(|e| {
-                    increment_download_count(shard_id, typ, "network", "error");
+                    increment_download_count(shard_id, typ, "external", "download_error");
+                    tracing::debug!(target: "sync", "Failed to download with error {}", e);
                     near_chain::Error::Other(format!("Failed to download: {}", e))
                 })
             }
@@ -94,7 +95,7 @@ impl StateSyncDownloadSource for StateSyncDownloadSourceExternal {
             )
             .await?;
             let header = ShardStateSyncResponseHeader::try_from_slice(&data).map_err(|e| {
-                increment_download_count(shard_id, "header", "external", "error");
+                increment_download_count(shard_id, "header", "external", "parse_error");
                 near_chain::Error::Other(format!("Failed to parse header: {}", e))
             })?;