fix: PageLocationChangeDetector's page dimensions differ is broken

saket · Sep 16, 2019 · f33ac56 · f33ac56
1 parent bcc400a
commit f33ac56
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/...clerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt b/...clerview/src/main/java/me/saket/inboxrecyclerview/animation/PageLocationChangeDetector.kt
@@ -16,8 +16,6 @@ internal class PageLocationChangeDetector(
   private var lastClippedDimens = Rect()
   private var lastState = page.currentState
 
-  private val rectBuffer = Rect()
-
   override fun onPreDraw(): Boolean {
     dispatchCallbackIfNeeded()
     return true
@@ -43,7 +41,7 @@ internal class PageLocationChangeDetector(
     lastTranslationY = page.translationY
     lastWidth = page.width
     lastHeight = page.height
-    lastClippedDimens.set(rectBuffer)
+    lastClippedDimens.set(page.clippedDimens)
     lastState = page.currentState
   }
 }
diff --git a/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/BaseExpandablePageLayout.kt b/inboxrecyclerview/src/main/java/me/saket/inboxrecyclerview/page/BaseExpandablePageLayout.kt
@@ -36,7 +36,6 @@ abstract class BaseExpandablePageLayout @JvmOverloads constructor(
 
     outlineProvider = object : ViewOutlineProvider() {
       override fun getOutline(view: View, outline: Outline) {
-        val clippedDimens = clippedDimens
         outline.setRect(0, 0, clippedDimens.width(), clippedDimens.height())
         outline.alpha = clippedDimens.height().toFloat() / height
       }