SAK-51005 Assignments invalid user can cause an NPE in peer review logic #13314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottenhoff
changed the title
| @@ -165,7 +161,7 @@ public void execute(String opaqueContext) { | |||
| AssignmentSubmission s = submissionIdMap.get(p.getId().getSubmissionId()); | |||
| Optional<AssignmentSubmissionSubmitter> ass = assignmentService.getSubmissionSubmittee(s);//Next, increment the count for studentAssessorsMap | |||
| String submitterId = assignmentService.getSubmitterIdForAssignment(assignment, ass.get().getSubmitter()); | |||
| Integer count = ass.isPresent() ? studentAssessorsMap.get(submitterId) : 0; | |||
| Integer count = studentAssessorsMap.get(submitterId); | |||
There was a problem hiding this comment.
Are you sure this doesn't introduce a potential NPE?
There was a problem hiding this comment.
The check is redundant because calling ass.get().getSubmitter() earlier already guarantees that the Optional is present—otherwise, an exception would have been thrown.
ern
changed the title
ern
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ern if you want any of this, please create a Jira.
The validUsers stuff seems fairly important. i believe event handling in assignments can throw an Exception causing important stuff (after saving an assignment) to fail ....
the PeerReview stuff is just optimization i think.