Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from nose to pytest on develop #702

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vassilit
Copy link
Collaborator

@vassilit vassilit commented Mar 5, 2025

No description provided.

@vassilit vassilit marked this pull request as draft March 5, 2025 21:18
nose is no longer maintained, see
nose-devs/nose#1099 (comment).

This was initially submitted here: https://bugs.gentoo.org/878695.

This commit switches to pytest.

Amongst the changes, here are the most relevant ones:
* Create a conftest.py that contains fixtures.
* Replace nose.with_setup with yield fixtures.
* Use pytest.skip instead of print and nose.plugins.skip.SkipTest.
* Use pytest.mark.slow instead of nose.plugins.attrib.attr("slow").
* Use pytest.mark.parametrize instead of parameterized, simplify
  parametrized tests that use both `shell` and `inverse_order`.
* Update Travis config.
* Update SConscript.
* Update documentation.

Co-developed-by: Vassili Tchersky <[email protected]>
@vassilit vassilit force-pushed the 603_sbraz_replace_nose branch from fad186e to 42cea86 Compare March 5, 2025 22:49
@vassilit vassilit marked this pull request as ready for review March 5, 2025 22:49
@vassilit
Copy link
Collaborator Author

vassilit commented Mar 5, 2025

@sbraz your migration to pytest was closer to the develop branch than the new master, so I rebased your work on this branch as well, as ultimately, they will merge.

Merci

@sbraz
Copy link
Contributor

sbraz commented Mar 5, 2025

Thanks a lot for handling this!

@vassilit
Copy link
Collaborator Author

vassilit commented Mar 5, 2025

Thanks a lot for handling this!

Merci à toi pour le patch initial, c'était du boulot qui est resté ignoré pendant des années et qui n'a pas empêché le retrait du paquet de Gentoo. J'espère pouvoir publier une nouvelle version d'ici la fin du mois.

@vassilit vassilit changed the title [Draft] Rebase #603 to develop Migration from nose to pytest on develop Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants