Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: created verification page #20

Merged
merged 8 commits into from
Jan 26, 2025

Conversation

Pvsaint
Copy link
Contributor

@Pvsaint Pvsaint commented Jan 23, 2025

Pull Request for SafeTrust - Close Issue number 9

❗ Pull Request Information

Changed the folder name from verification _page to verification-center
integrated shadcn

Add here some information

πŸŒ€ Summary of Changes

  • Add here the changes:
  • More changes:

πŸ›  Testing

Evidence Before Solution

Evidence After Solution

πŸ“‚ Related Issue

This pull request will close # [9] upon merging.


Make sure to follow the Git Guidelines for Atomic Commits and read Contributing Guide

The Pull request needs to have the format mentioned below in the Git Guideline

πŸŽ‰ Thank you for reviewing this PR! πŸŽ‰

@Pvsaint Pvsaint marked this pull request as draft January 23, 2025 21:14
@Pvsaint Pvsaint marked this pull request as ready for review January 24, 2025 20:12
@JosueBrenes
Copy link
Contributor

Hi @Pvsaint

There are several changes to make for the pr to be ready.

1 - Rename this folder to "verification-center"

image

2 - You didn't use shadcn for the components, migrate everything to that just as it is in the issue. If you don't know how to use it, I leave you the documentation. https://ui.shadcn.com/docs

That would be all, thank you very much

@Pvsaint
Copy link
Contributor Author

Pvsaint commented Jan 25, 2025

Ok boss

Hi @Pvsaint

There are several changes to make for the pr to be ready.

1 - Rename this folder to "verification-center"

image

2 - You didn't use shadcn for the components, migrate everything to that just as it is in the issue. If you don't know how to use it, I leave you the documentation. https://ui.shadcn.com/docs

That would be all, thank you very much

@Pvsaint
Copy link
Contributor Author

Pvsaint commented Jan 26, 2025

@JosueBrenes
please review the code, all corrections have been made.

@JosueBrenes
Copy link
Contributor

Hi @Pvsaint

What command did you use to install the label component?

It is presenting problems like this

Use the command that is there
https://ui.shadcn.com/docs/components/label (npx shadcn@latest add label)

Using the command there solves any error, make that change and we would be

@Pvsaint
Copy link
Contributor Author

Pvsaint commented Jan 26, 2025

Hi @Pvsaint

What command did you use to install the label component?

It is presenting problems like this

Use the command that is there https://ui.shadcn.com/docs/components/label (npx shadcn@latest add label)

Using the command there solves any error, make that change and we would be

Done!

@JosueBrenes JosueBrenes merged commit 79786bd into safetrustcr:main Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants