Upload build output using parallel threads #4842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What it solves Identical to safe-global/safe-docs#680 and safe-global/safe-homepage#541, this fix aims to drastically reduce deployment times to AWS. ## How this PR fixes it The issue is solved by uploading files in parallel using the `&` operator.
|
Pretty sure it's not good to launch so many processes in parallel. There are |
katspaugh
reviewed
Jan 28, 2025
Comment on lines
15
to
+20
| for file in $(find . -name '*.html' | sed 's|^\./||'); do | ||
| aws s3 cp ${file%} $BUCKET/${file%.*} --content-type 'text/html' | ||
| aws s3 cp ${file%} $BUCKET/${file%.*} --content-type 'text/html' & | ||
| done | ||
|
|
||
| wait | ||
|
|
There was a problem hiding this comment.
ChatGPT suggested we can run them in batches like so:
# Max number of parallel processes
MAX_PARALLEL=20
# Counter to track the number of running processes
counter=0
for file in $(find . -name '*.html' | sed 's|^\./||'); do
# Launch the process
aws s3 cp "${file%}" "$BUCKET/${file%.*}" --content-type 'text/html' &
# Increment the counter
((counter++))
# If the counter reaches the max limit, wait for all processes to complete
if ((counter >= MAX_PARALLEL)); then
wait
counter=0
fi
done
# Wait for any remaining processes to complete
wait
|
Closed in favor of #4843 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Identical to safe-global/safe-docs#680 and safe-global/safe-homepage#541, this fix aims to drastically reduce deployment times to AWS.
How this PR fixes it
The issue is solved by uploading files in parallel using the
&operator.