Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "to" field to PENDING and EXECUTED multisig tx events #2378

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add "to" field to PENDING and EXECUTED multisig tx events #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions safe_transaction_service/history/services/notification_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def build_event_payload(
"address": instance.safe,
# 'type': None, It will be assigned later
"safeTxHash": HexBytes(instance.safe_tx_hash).hex(),
"to": instance.to,
}
if instance.executed:
payload["type"] = (
Expand Down
1 change: 1 addition & 0 deletions safe_transaction_service/history/tests/test_signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ def test_signals_are_correctly_fired(self, send_event_mock: MagicMock):
multisig_tx: MultisigTransaction = MultisigTransactionFactory(trusted=True)
pending_multisig_transaction_payload = {
"address": multisig_tx.safe,
"to": multisig_tx.to,
"safeTxHash": multisig_tx.safe_tx_hash,
"type": TransactionServiceEventType.EXECUTED_MULTISIG_TRANSACTION.name,
"failed": "false",
Expand Down
Loading