Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only return trusted multisig txs by default #1842

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Only return trusted multisig txs by default #1842

merged 1 commit into from
Jan 26, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jan 26, 2024

  • Currently all txs were returned in multisig-txs endpoint

@Uxio0 Uxio0 requested a review from a team as a code owner January 26, 2024 09:50
@Uxio0 Uxio0 force-pushed the trusted-multisig-txs-by-default branch 2 times, most recently from bf5c97a to a7f77b4 Compare January 26, 2024 12:27
@Uxio0 Uxio0 self-assigned this Jan 26, 2024
@Uxio0 Uxio0 mentioned this pull request Jan 26, 2024
Closed
moisses89
moisses89 reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should add in swagger doc that the default return value is returned for Trusted = True

@Uxio0
Only return trusted multisig txs by default
2939f44 
- Currently all txs were returned in multisig-txs endpoint
@Uxio0 Uxio0 force-pushed the trusted-multisig-txs-by-default branch from a7f77b4 to 2939f44 Compare January 26, 2024 15:33
@Uxio0 Uxio0 merged commit 773ab9d into master Jan 26, 2024
3 checks passed
@Uxio0 Uxio0 deleted the trusted-multisig-txs-by-default branch January 26, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees

@Uxio0 Uxio0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uxio0 @moisses89