[Certora Audit] G-08. Use shift right/left instead of division/multiplication if possible #895
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
approved these changes
Jan 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes optimizations to the gas usage in the
Safe.solandStorageAccessible.solcontracts by replacing multiplication operations with bitwise shift operations. While theDIV / MULopcode uses 5 gas, theSHR / SHLopcode only uses 3 gas.Gas optimization changes:
contracts/Safe.sol: Replaced the multiplication operation* 64with the bitwise shift operation<< 6to reduce gas costs in thegasleftcheck.contracts/common/StorageAccessible.sol: Replaced the multiplication operation* 32with the bitwise shift operation<< 5to reduce gas costs when creating a new bytes array.