feat: Signer hooks #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…old, owners and whether it is deployed Update `useSafeClient` hook to return a function resolving with the curent SafeClient instance
…rate a config object
… in `useSignerAddress` hook
This is only temporary until the new kit is released.
… in github workflow
dasanra
reviewed
Aug 13, 2024
yagopv
reviewed
Aug 16, 2024
yagopv
reviewed
Aug 16, 2024
yagopv
reviewed
Aug 16, 2024
yagopv
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds new hooks for handling a signer:
useAuthenticate: Provides functions to connect or disconnect a signer.useSignerAddress: Provides the address of the connected signer.Refactored the client logic
Separation of public and signer client
There are two clients now: a publicClient and a signerClient. This is necessary to be able to update the signer separately from the global config, which would initialize a new publicClient for each config update.
Moved the clients to the context
The client instances are stored in the SafeContext now. This makes sure that a common SafeClient instance is used for all hooks, instead of initializing new instances for each hook.
Error handling
Improved the error handling and added some custom error classes:
AuthenticationError,InitializeSafeProviderError, andMissingSafeProviderError.Add Github workflow for unit tests
Added a workflow to run the unit tests. Since the
sdk-starter-kitis not published yet, the workflow contains temporary steps to use thesafe-core-sdkrepo as a local dependency. The workflow checks out the repo using thesdk-starter-kitbranch and the dependency in the package.json uses the local package.Demo
The new signer feature is used on this PR for the demo app.