Fix docker image build #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Uxio0
commented
Nov 28, 2023
Uxio0
commented
- Remove not needed dependencies
- Add gunicorn missing configuration
- Organize .env samples
- Update README.md
- Make sure swagger works
- Closes Add swagger #4
moisses89
reviewed
Nov 28, 2023
| docker compose up | ||
| ``` | ||
|
|
||
| Then go to http://localhost:8000 |
There was a problem hiding this comment.
I'm thinking that we are mixing configuration and execution here, could we separate them in different sections?
| @@ -38,4 +38,4 @@ COPY --chown=python:python . . | |||
| # Use numeric ids so kubernetes identifies the user correctly | |||
| USER 999:999 | |||
|
|
|||
| RUN DJANGO_SETTINGS_MODULE=config.settings.production DJANGO_DOT_ENV_FILE=.env.tracing.sample python manage.py collectstatic --noinput | |||
| RUN DJANGO_SETTINGS_MODULE=config.settings.production DJANGO_DOT_ENV_FILE=.env.sample python manage.py collectstatic --noinput | |||
There was a problem hiding this comment.
I suppose that here should be .env instead .env.sample.
There was a problem hiding this comment.
No, as this is only a placeholder as it needs a file to exist, so it doesn't matter which one, but good catch
- Update dockerignore - Remove not needed dependencies - Add gunicorn missing configuration - Organize .env samples - Update README.md - Make sure swagger works - Closes #4
moisses89
approved these changes
Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.