Add price endpoint #22
Conversation
Uxio0
commented
Nov 20, 2023
Uxio0
commented
- Closes Add price endpoint #3
Uxio0
force-pushed
the
add-price-endpoint
branch
from
236f32f to
6307d31
Compare
| DEBUG=0 | ||
| DJANGO_SETTINGS_MODULE=config.settings.test | ||
| DJANGO_SECRET_KEY=t3st-s3cr3t#-!k3y | ||
| ETHEREUM_NODES_URLS=https://ethereum.publicnode.com,https://polygon-rpc.com |
There was a problem hiding this comment.
Can this be an array? just to be more specific [https://ethereum.publicnode.com, ...]
There was a problem hiding this comment.
No, enviroment variables cannot be arrays, they usually are comma separated values.
We are currently using python-environ to parse them, take a look at https://pypi.org/project/python-environ/
| DEBUG=0 | ||
| DJANGO_SETTINGS_MODULE=config.settings.test | ||
| DJANGO_SECRET_KEY=t3st-s3cr3t#-!k3y | ||
| ETHEREUM_MAINNET_NODE=https://ethereum.publicnode.com |
There was a problem hiding this comment.
Which is the difference between ETHEREUM_MAINNET_NODE and ETHEREUM_NODES_URLS, also why ETHEREUM_MAINNET_NODE is not in the .env.sample?
There was a problem hiding this comment.
ETHEREUM_MAINNET_NODE is only used for tests, a ethereum mainnet node is required for e2e price oracle tests (same as we do for safe-eth-py or safe-transaction-service)
| ## Configuration | ||
|
|
||
| Environment variables: | ||
| - `ETHEREUM_NODES_URLS`: Comma separated list of the node RPCS for the chains supported for fetching prices. |
There was a problem hiding this comment.
ETHEREUM_MAINNET_NODE is not mentioned here.
| SWAGGER_SETTINGS = { | ||
| "SECURITY_DEFINITIONS": { | ||
| "api_key": {"type": "apiKey", "in": "header", "name": "Authorization"} | ||
| }, | ||
| } | ||
|
|
||
| # Ethereum | ||
| ETHEREUM_NODE_URL = env("ETHEREUM_NODE_URL", default=None) |
There was a problem hiding this comment.
ETHEREUM_NODE_URL is also ETHEREUM_MAINNET_NODE?
| COPY . . | ||
| # /nginx mount point must be created before so it doesn't have root permissions | ||
| # ${APP_HOME} root folder will not be updated by COPY --chown, so permissions need to be adjusted | ||
| RUN groupadd -g 999 python && \ |
There was a problem hiding this comment.
Maybe is better 1000 here, what do you think?
| @@ -0,0 +1,8 @@ | |||
| CRYPTO_KITTIES_CONTRACT_ADDRESSES = { | |||
| "0x06012c8cf97BEaD5deAe237070F9587f8E7A266d", # Mainnet | |||
| "0x16baF0dE678E52367adC69fD067E5eDd1D33e3bF", # Rinkeby | |||
There was a problem hiding this comment.
That constants file is not required at all, thanks for noticing
