Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 4337 Asset Lists #37

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

bh2smith
Copy link
Contributor

In some cases I compared the byte code with diff checker

v0.2.0 mainnet: https://www.diffchecker.com/ebvOi5Ms/

but most cases I just checked for existence of a contract and the first few bytes. here are the scan links to all the v0.3.0 networks added:

ChainId Deployment
1 Etherscan
10 Optimistic Etherscan
56 BSCScan
97 Testnet BSCScan
100 GnosisScan
137 PolygonScan
8453 BaseScan
42161 Arbiscan
84532 Sepolia BaseScan
421614 Sepolia Arbiscan

@bh2smith bh2smith requested a review from a team as a code owner September 15, 2024 06:52
@bh2smith bh2smith requested review from nlordell, akshay-ap, mmv08 and remedcu and removed request for a team September 15, 2024 06:52
bh2smith added a commit to BitteProtocol/near-safe that referenced this pull request Sep 15, 2024
The Safe Deployment network lists we outdated, causing us to fallback on v0.2.0 contracts (totally undesired - due to loss of identical & deterministic addresses on all chains). We proposed an update here safe-global/safe-modules-deployments#37

This PR just falls back on Sepolia for the deployment data (when not found in the list). This shouldn't cause problems in cases when the assets are deployed, but the user will run into issues on networks where the assets don't yet exist.

The proper solution here is proposed in #42 (the answer to life existence and everything).
@remedcu remedcu merged commit b9304bf into safe-global:main Sep 16, 2024
1 check passed
@bh2smith bh2smith deleted the update-assets branch September 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants