Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small fixes #65

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add small fixes #65

merged 1 commit into from
Jan 16, 2025

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jan 15, 2025

No description provided.

@Uxio0 Uxio0 requested a review from a team as a code owner January 15, 2025 16:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12792255458

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 93.631%

Totals Coverage Status
Change from base Build 12786325540: -0.06%
Covered Lines: 838
Relevant Lines: 895

💛 - Coveralls

app/datasources/db/models.py Show resolved Hide resolved
@@ -55,6 +55,7 @@ async def get_contract_metadata_task(
address,
chain_id,
)
# TODO Check if contract is MultiSend. In that case, get the transaction and decode it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check should be here or in the rabbitmq consumer?
Other topic is that we are not checking if a contract is really a contract, we are trying to download every address. Should we check this first?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not saying that we should do it here, but we should be aware: #67

@Uxio0 Uxio0 merged commit 398a226 into main Jan 16, 2025
5 checks passed
@Uxio0 Uxio0 deleted the fixes branch January 16, 2025 11:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants