Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update proxies task #64

Merged
merged 9 commits into from
Jan 16, 2025
Merged

Add update proxies task #64

merged 9 commits into from
Jan 16, 2025

Conversation

moisses89
Copy link
Member

Closes #53

@moisses89 moisses89 requested a review from a team as a code owner January 15, 2025 12:34
@moisses89 moisses89 changed the title Add test to ensure contracts are being updated Add update proxies task Jan 15, 2025
@coveralls
Copy link

coveralls commented Jan 15, 2025

Pull Request Test Coverage Report for Build 12805339397

Details

  • 25 of 30 (83.33%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.7%) to 92.998%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/workers/tasks.py 17 22 77.27%
Files with Coverage Reduction New Missed Lines %
app/datasources/db/models.py 1 98.52%
app/workers/tasks.py 1 86.96%
app/services/contract_metadata_service.py 2 98.25%
Totals Coverage Status
Change from base Build 12786325540: -0.7%
Covered Lines: 850
Relevant Lines: 914

💛 - Coveralls

app/datasources/db/models.py Outdated Show resolved Hide resolved
app/datasources/db/models.py Outdated Show resolved Hide resolved
app/workers/tasks.py Show resolved Hide resolved
@moisses89 moisses89 merged commit 3dddc3b into main Jan 16, 2025
5 checks passed
@moisses89 moisses89 deleted the update_proxies branch January 16, 2025 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add periodic task to update implemnentation address for proxies
3 participants