Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse the session between requests #21

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Reuse the session between requests #21

merged 1 commit into from
Dec 11, 2024

Conversation

moisses89
Copy link
Member

Description

Previous implementation created a new session for each database interaction, the current want search to reuse the same connection between inside of each API request.
Keeps the decorator to use it on testing and dramatiq tasks.

@moisses89 moisses89 requested a review from a team as a code owner December 11, 2024 13:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12277152702

Details

  • 21 of 22 (95.45%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 90.164%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/datasources/db/database.py 12 13 92.31%
Totals Coverage Status
Change from base Build 12263372924: -0.3%
Covered Lines: 110
Relevant Lines: 122
💛 - Coveralls

@moisses89 moisses89 merged commit d388110 into main Dec 11, 2024
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moisses89 @coveralls @Uxio0