Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get Safe contracts from safe-deployments #91

Merged
merged 36 commits into from
Nov 16, 2021
Merged

Get Safe contracts from safe-deployments #91

merged 36 commits into from
Nov 16, 2021

Conversation

germartinez
Copy link
Member

@germartinez germartinez commented Oct 15, 2021 •
edited
Loading

What it solves

Resolves #25
Resolves #12

How this PR fixes it

It removes the default local configuration with the Safe contract addresses and uses the contracts returned from safe-deployments package.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@germartinez germartinez linked an issue Oct 15, 2021 that may be closed by this pull request
Use safe-deployments to handle contract versions #25
Closed
@germartinez
Merge branch 'development' into safe-deployments
2e934e0
@germartinez
handle different Safe versions in EthAdapters
33872c1
@germartinez
Use types from last version of the Safe contracts (backwards compatible)
ef70053
@germartinez
Allow deployment of multiple Safe versions
5cbb203
@germartinez
Rename SafeContract classes
32c2591
@germartinez
Update properties of SafeFactory in README file
69363c9
@germartinez
Set default Safe contracts version
7a55d37
@germartinez
Remove unused ABI files
23b42eb
@germartinez
Add more properties to SafeAccountConfig in README
8ee4765
@germartinez
Add all GnosisSafeContract classes depending on the version
530333d
@germartinez
Add all SafeProxyFactory classes depending on the version
6f8ce4a
@germartinez
Add all MultiSendContract classes depending on the version
975fefe
@germartinez
Remove typechain files generation for v1.0.0
68cffd3
@germartinez
Rename SAFE_LAST_VERSION constant
57ccb42
@germartinez
Get Safe contracts typed instances depending on the version
0053184
@germartinez
Stop using defaultAddress from safe-deployments
3f54e61
@germartinez
Compile and generate types for Safe versions
d9da697
@germartinez
Fix typechain script for contracts in tests
8cdde74
@germartinez
Setup contracts deployment in tests
60ed6a1
@germartinez
Fix implementation of GnosisSafeContract classes
4f0f05f
@germartinez
Remove "v" from Safe version numbers
853ffa9
iamacook
iamacook reviewed Nov 8, 2021
View reviewed changes
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I found a few things.

packages/safe-core-sdk/README.md Outdated Show resolved Hide resolved
packages/safe-core-sdk/hardhat/deploy/deploy-contracts.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/scripts/generateTypechainFiles.ts Show resolved Hide resolved
packages/safe-core-sdk/scripts/generateTypechainFiles.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/scripts/generateTypechainFiles.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/src/contracts/contractInstancesWeb3.ts Show resolved Hide resolved
packages/safe-core-sdk/src/contracts/safeDeploymentContracts.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/src/managers/contractManager.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/src/safeFactory/index.ts Outdated Show resolved Hide resolved
packages/safe-core-sdk/tests/utils/setupContracts.ts Outdated Show resolved Hide resolved
@germartinez germartinez requested a review from iamacook November 16, 2021 11:23
iamacook
iamacook approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@germartinez germartinez merged commit d5a7021 into development Nov 16, 2021
@germartinez germartinez deleted the safe-deployments branch November 16, 2021 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamacook iamacook iamacook approved these changes

@DiogoSoaress DiogoSoaress Awaiting requested review from DiogoSoaress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use safe-deployments to handle contract versions
3 participants
@germartinez @iamacook @Lipstick93Chels