Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release #1097

Merged
merged 8 commits into from
Jan 20, 2025
Prev Previous commit
Next Next commit
chore: fix typos (#1096)
dasanra authored Jan 15, 2025
commit 6d75e96289b48d126a1dca236c6825d2f10778ab
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ You will need to agree to [our CLA](https://safe.global/cla) in order to be poss

### Starting Guide

By following the steps bellow you will understand the development process and worflow.
By following the steps below you will understand the development process and workflow.
1. [Forking the repository](#forking-the-repository)
2. [Installing Node and Yarn](#installing-node-and-yarn)
3. [Installing dependencies](#installing-dependencies)
@@ -44,7 +44,7 @@ yarn -v

#### Installing dependencies

The Safe{Core} SDK uses a mono-repository structure managed by [Yarn Workspaces](https://classic.yarnpkg.com/lang/en/docs/workspaces/) and [Lerna](https://lerna.js.org). From the root of the repository you will need to install the whole dependency stack and do the project build. Some packages depend on each other, so even when modifiying only one package it's better to run the full build.
The Safe{Core} SDK uses a mono-repository structure managed by [Yarn Workspaces](https://classic.yarnpkg.com/lang/en/docs/workspaces/) and [Lerna](https://lerna.js.org). From the root of the repository you will need to install the whole dependency stack and do the project build. Some packages depend on each other, so even when modifying only one package it's better to run the full build.

Install all dependencies and build the whole project by using the following commands at the project root.

2 changes: 1 addition & 1 deletion playground/README.md
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ In case you want to execute the transaction via a transaction relay, this script
yarn play relay-sponsored-transaction
```

#### Generate a custon Safe address
#### Generate a custom Safe address

This script allows to find the right `saltNonce` to generate a vanity Safe address with any given configuration:


Unchanged files with check annotations Beta

* @throws "Not Found"
* @throws "Ensure this field has at least 1 hexadecimal chars (not counting 0x)."
*/
async decodeData(data: string, to?: string): Promise<any> {

Check warning on line 125 in packages/api-kit/src/SafeApiKit.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
if (data === '') {
throw new Error('Invalid data')
}
const { address: delegator } = this.#getEip3770Address(delegatorAddress)
const signature = await signDelegate(signer, delegate, this.#chainId)
const body: any = {

Check warning on line 342 in packages/api-kit/src/SafeApiKit.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
safe: safeAddress ? this.#getEip3770Address(safeAddress).address : null,
delegate,
delegator,
interface HttpRequest {
url: string
method: HttpMethod
body?: any

Check warning on line 12 in packages/api-kit/src/utils/httpRequests.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
}
export async function sendRequest<T>({ url, method, body }: HttpRequest): Promise<T> {
body: JSON.stringify(body)
})
let jsonResponse: any

Check warning on line 25 in packages/api-kit/src/utils/httpRequests.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
try {
jsonResponse = await response.json()
} catch (error) {
}
// TODO: fix anys
encodeParameters(types: string, values: any[]): string {

Check warning on line 366 in packages/protocol-kit/src/SafeProvider.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
return encodeAbiParameters(parseAbiParameters(types), values)
}
decodeParameters(types: string, values: string): { [key: string]: any } {

Check warning on line 370 in packages/protocol-kit/src/SafeProvider.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
return decodeAbiParameters(parseAbiParameters(types), asHex(values))
}
functionName
>
>(functionName: functionName, args: functionArgs, options?: TransactionOptions) {
const converted = this.convertOptions(options) as any

Check warning on line 219 in packages/protocol-kit/src/contracts/BaseContract.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
return await this.getWallet().writeContract({
address: this.contractAddress,
}
}
export function isTypedDataSigner(signer: any): signer is Client {

Check warning on line 507 in packages/protocol-kit/src/contracts/utils.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
const isPasskeySigner = !!signer?.passkeyRawId
return (signer as unknown as WalletClient).signTypedData !== undefined || !isPasskeySigner
}
return typeof blockId === 'number' ? blockNumber(blockId) : blockTag(blockId)
}
function blockNumber(blockNumber: any) {

Check warning on line 7 in packages/protocol-kit/src/utils/block.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
return { blockNumber: blockNumber.toNumber() }
}
function blockTag(blockTag: any) {

Check warning on line 11 in packages/protocol-kit/src/utils/block.ts

GitHub Actions / eslint

Unexpected any. Specify a different type
return { blockTag: blockTag as BlockTag }
}