Skip to content

Commit

Permalink
Not neccesary sharedSigner
Browse files Browse the repository at this point in the history
  • Loading branch information
yagopv committed Jan 31, 2025
1 parent 0a3842f commit bd31756
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 15 deletions.
2 changes: 0 additions & 2 deletions packages/relay-kit/src/packs/safe-4337/Safe4337Pack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,6 @@ export class Safe4337Pack extends RelayKitBasePack<{
chainId: this.#chainId,
moduleAddress: this.#SAFE_4337_MODULE_ADDRESS,
entryPoint: this.#ENTRYPOINT_ADDRESS,
sharedSigner: this.#SAFE_WEBAUTHN_SHARED_SIGNER_ADDRESS,
validUntil,
validAfter
})
Expand Down Expand Up @@ -528,7 +527,6 @@ export class Safe4337Pack extends RelayKitBasePack<{
{
chainId: this.#chainId,
moduleAddress: this.#SAFE_4337_MODULE_ADDRESS,
sharedSigner: this.#SAFE_WEBAUTHN_SHARED_SIGNER_ADDRESS,
entryPoint: userOperation?.entryPoint || this.#ENTRYPOINT_ADDRESS,
validAfter: this.#timestamp(validAfter),
validUntil: this.#timestamp(validUntil)
Expand Down
15 changes: 5 additions & 10 deletions packages/relay-kit/src/packs/safe-4337/SafeOperation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ describe('SafeOperation', () => {
const safeOperation = new SafeOperationV06(fixtures.USER_OPERATION, {
chainId: BigInt(fixtures.CHAIN_ID),
moduleAddress: fixtures.MODULE_ADDRESS,
entryPoint: fixtures.ENTRYPOINTS[0],
sharedSigner: fixtures.SHARED_SIGNER
entryPoint: fixtures.ENTRYPOINTS[0]
})

expect(safeOperation.getSafeOperation()).toMatchObject({
Expand All @@ -35,8 +34,7 @@ describe('SafeOperation', () => {
const safeOperation = new SafeOperationV06(fixtures.USER_OPERATION, {
chainId: BigInt(fixtures.CHAIN_ID),
moduleAddress: fixtures.MODULE_ADDRESS,
entryPoint: fixtures.ENTRYPOINTS[0],
sharedSigner: fixtures.SHARED_SIGNER
entryPoint: fixtures.ENTRYPOINTS[0]
})

safeOperation.addSignature(new EthSafeSignature('0xSigner', '0xSignature'))
Expand All @@ -53,8 +51,7 @@ describe('SafeOperation', () => {
const safeOperation = new SafeOperationV06(fixtures.USER_OPERATION, {
chainId: BigInt(fixtures.CHAIN_ID),
moduleAddress: fixtures.MODULE_ADDRESS,
entryPoint: fixtures.ENTRYPOINTS[0],
sharedSigner: fixtures.SHARED_SIGNER
entryPoint: fixtures.ENTRYPOINTS[0]
})

safeOperation.addSignature(new EthSafeSignature('0xSigner1', '0xSignature1'))
Expand All @@ -67,8 +64,7 @@ describe('SafeOperation', () => {
const safeOperation = new SafeOperationV06(fixtures.USER_OPERATION, {
chainId: BigInt(fixtures.CHAIN_ID),
moduleAddress: fixtures.MODULE_ADDRESS,
entryPoint: fixtures.ENTRYPOINTS[0],
sharedSigner: fixtures.SHARED_SIGNER
entryPoint: fixtures.ENTRYPOINTS[0]
})

safeOperation.addEstimations({
Expand Down Expand Up @@ -98,8 +94,7 @@ describe('SafeOperation', () => {
const safeOperation = new SafeOperationV06(fixtures.USER_OPERATION, {
chainId: BigInt(fixtures.CHAIN_ID),
moduleAddress: fixtures.MODULE_ADDRESS,
entryPoint: fixtures.ENTRYPOINTS[0],
sharedSigner: fixtures.SHARED_SIGNER
entryPoint: fixtures.ENTRYPOINTS[0]
})

safeOperation.addSignature(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ const SAFE_OPERATION = new SafeOperationV06(
{
chainId: 1n,
entryPoint: '0xEntryPoint',
moduleAddress: '0xModuleAddress',
sharedSigner: '0xSharedSigner'
moduleAddress: '0xModuleAddress'
}
)

Expand Down
1 change: 0 additions & 1 deletion packages/types-kit/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,6 @@ export type SafeOperationOptions = {
moduleAddress: string
entryPoint: string
chainId: bigint
sharedSigner: string
validAfter?: number
validUntil?: number
}
Expand Down

0 comments on commit bd31756

Please sign in to comment.