Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

271 kubernetes helm chart #403

Closed
wants to merge 4 commits into from
Closed

271 kubernetes helm chart #403

wants to merge 4 commits into from

Conversation

acouvreur
Copy link
Member

Supersed #274

@github-actions github-actions bot added the reverse-proxy Reverse proxy integration related issue label Sep 16, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 16, 2024
View reviewed changes
helm/templates/deployment.yaml Fixed Show fixed Hide fixed
helm/templates/deployment.yaml
spec:
serviceAccountName: sablier-{{ .Release.Name }}
containers:
- name: sablier

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarCloud
helm/templates/deployment.yaml
spec:
serviceAccountName: sablier-{{ .Release.Name }}
containers:
- name: sablier

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium

Specify a storage limit for this container. See more on SonarCloud
MrLuje
MrLuje reviewed Oct 5, 2024
View reviewed changes
helm/templates/rbac.yaml Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 12, 2024
View reviewed changes
helm/templates/deployment.yaml
{{ toYaml . | nindent 8 }}
{{- end }}
spec:
serviceAccountName: sablier-{{ .Release.Name }}

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this Service Account to RBAC or disable "automountServiceAccountToken". See more on SonarCloud
@acouvreur
Copy link
Member Author

Hello everyone, as mentioned I will be moving this to a new organization. So I've actually baked the helm chart: https://github.com/sablierapp/helm-charts

You can start testing it! I'm sure there will be some issues but it's a first :)

@acouvreur acouvreur closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrLuje MrLuje MrLuje left review comments

Assignees
No one assigned
Labels
reverse-proxy Reverse proxy integration related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acouvreur @MrLuje