test(refactor): move all variables into Constants contract

[smol-ninja]

Closes #63

[andreivladbrg]

my suggestion in that issue was to completely remove Defaults or import it into Base_Test, so we don’t have to call anything like defaults.<foo>

i don’t see the point of leaving some things in Defaults while moving others into Base_Test.

so i would rather:

1. move the index<num>Proof functions back to Defaults and import it into Base_Test, or
2. completely move the function from Defaults into Base_Test.

both work for me

[smol-ninja]

Sounds good. I will move everything into Base. That looks a better design to me.

[smol-ninja]

Included your suggestion of removing Defaults contract @andreivladbrg.

[andreivladbrg]

after seeing the actual functions from Base_Test now, and at the same time keeping in mind the fact that we will import and use evm-utils, and the file tests/utils/Utils.sol will be removed after that change

another idea came to mind: what if we move all these functions into Utils? IMO they are more of utility functions, especially the compute address functions and tranchesMerkleLT.

even though the current version works, just asking as i believe we can improve it (and sorry for so many changes :)) )

[smol-ninja]

I didn't get what you meant in your first sentence. We will have to keep Base.t.sol anyhow because the setUp has some bespoke implementation such as merkleFactory.setMinimumFee(defaults.MINIMUM_FEE()).

Also, with respect to moving those function to Utils, you pointed to the previous file. After the PR, the Base contains few more functions as you can see here. Plus Base inherits from Constants as well.

Regardless, after evm-utils, we should still have Base file.

[andreivladbrg]

I didn't get what you meant in your first sentence. We will have to keep Base.t.sol anyhow because the setUp has some bespoke implementation such as merkleFactory.setMinimumFee(defaults.MINIMUM_FEE()).

i have not said anything about Base.t.sol, but Utils.sol, which has all these functions, that can be found in evm-utils, thus we will be removing it once we install that here. and now, with this idea in mind (the fact that we - in the future - we will not have a tests/utils/Utils.sol anymore) what if we now move these functions (also pointed out in above message) in tests/utils/Utils.sol?

you pointed to the previous file

sorry about that, edited the above message

lmk if i've made self clear now

[smol-ninja]

As discussed on Slack, lets leave those functions in Base for now and re-assess it in the evm-utils PR.

[smol-ninja]

I have resolved the conflicts on this PR and changed the base branch to refactor/multiple-factories

[andreivladbrg]

left some comments:

[andreivladbrg]

pushed a commit dddc3c7

lmk if you don't agree with the changes and have a strong opinion about the previous version. if you don't, feel free to mark the comments above as resolved. i find it better this way

[smol-ninja]

gtg. Thanks for the feedback.