Skip to content

Upgrade to Rector 2.0 with PHPStan 2 and PHPParser 5 #1584

Upgrade to Rector 2.0 with PHPStan 2 and PHPParser 5

Upgrade to Rector 2.0 with PHPStan 2 and PHPParser 5 #1584

Triggered via pull request November 21, 2024 08:56
Status Failure
Total duration 38s
Artifacts

code_analysis.yaml

on: pull_request
Matrix: code_analysis
Fit to window
Zoom out
Zoom in

Annotations

65 errors
8.1 Tests
Process completed with exit code 2.
8 PHPStan
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8 Tests
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8 Composer Validate
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.2 Tests
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.2 Tests
Process completed with exit code 2.
8.3 PHP Linter
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.3 PHP Linter
The operation was canceled.
8.1 Check TYPO3 Rector configs
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.3 Tests
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.3 Tests
The operation was canceled.
7.4 PHP Linter
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.1 PHP Linter
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.1 Composer Validate
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.1 PHPStan
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.1 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L114
Strict comparison using === between non-empty-array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.1 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L145
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.1 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L163
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.1 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddStaticFileIntoTCAOverridesRector.php#L129
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
8.1 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L134
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
8.1 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L162
Instanceof between PhpParser\Node\Expr\Variable and PhpParser\Node\Expr\Variable will always evaluate to true.
8.1 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 1 so it can be removed from the return type.
8.1 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 2 so it can be removed from the return type.
8.1 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 4 so it can be removed from the return type.
8.1 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns PhpParser\Node so it can be removed from the return type.
8.2 Composer Validate
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.2 PHPStan
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.2 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L114
Strict comparison using === between non-empty-array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.2 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L145
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.2 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L163
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.2 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddStaticFileIntoTCAOverridesRector.php#L129
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
8.2 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L134
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
8.2 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L162
Instanceof between PhpParser\Node\Expr\Variable and PhpParser\Node\Expr\Variable will always evaluate to true.
8.2 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 1 so it can be removed from the return type.
8.2 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 2 so it can be removed from the return type.
8.2 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 4 so it can be removed from the return type.
8.2 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns PhpParser\Node so it can be removed from the return type.
8.3 PHPStan
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.3 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L114
Strict comparison using === between non-empty-array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.3 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L145
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
8.3 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L163
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
7.4 Tests
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.3 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddStaticFileIntoTCAOverridesRector.php#L129
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
7.4 Tests
The operation was canceled.
8.3 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L134
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
8.3 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L162
Instanceof between PhpParser\Node\Expr\Variable and PhpParser\Node\Expr\Variable will always evaluate to true.
8.3 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 1 so it can be removed from the return type.
8.3 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 2 so it can be removed from the return type.
8.3 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 4 so it can be removed from the return type.
8.3 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns PhpParser\Node so it can be removed from the return type.
8.3 Check TYPO3 Rector configs
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8.3 Check TYPO3 Rector configs
The operation was canceled.
7.4 PHPStan
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
7.4 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L114
Strict comparison using === between non-empty-array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
7.4 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L145
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
7.4 PHPStan: rules/CodeQuality/General/ExtEmConfRector.php#L163
Strict comparison using === between array<PhpParser\Node\ArrayItem> and null will always evaluate to false.
7.4 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddStaticFileIntoTCAOverridesRector.php#L129
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
7.4 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L134
Fetching deprecated class constant REMOVE_NODE of class PhpParser\NodeTraverser: Use NodeVisitor::REMOVE_NODE instead.
7.4 PHPStan: rules/CodeQuality/General/MoveExtensionManagementUtilityAddToAllTCAtypesIntoTCAOverridesRector.php#L162
Instanceof between PhpParser\Node\Expr\Variable and PhpParser\Node\Expr\Variable will always evaluate to true.
7.4 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 1 so it can be removed from the return type.
7.4 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 2 so it can be removed from the return type.
7.4 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns 4 so it can be removed from the return type.
7.4 PHPStan: rules/CodeQuality/General/MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector.php#L87
Method Ssch\TYPO3Rector\CodeQuality\General\MoveExtensionUtilityRegisterPluginIntoTCAOverridesRector::refactor() never returns PhpParser\Node so it can be removed from the return type.
8 PHP Linter
The job was canceled because "_8_1_Tests_vendor_bin_php" failed.
8 PHP Linter
A task was canceled.