support ubuntu path (~/snap/...)

[saadtazi]

if linux, check if default firefox/ dir is present, if not, use ubuntu path.

[jrom99]

I haven't tested my code yet, but it was along the same lines:

snapDir = ...
dotDir = ...

xdgConfigDir = process.env.XDG_CONFIG_HOME || path.join(process.env.HOME, ".config")
xdgDir = path.join(xdgConfigDir, "mozilla/firefox")
if (fs.existsSync(dotDir)) { userDir = dotDir }
else if (fs.existsSync(snapDir)) { userDir = snapDir }
else { userDir = xdgDir }

[saadtazi]

Ah, I wasn't sure what the XDG_CONFIG_HOME was used for, thank you!

[saadtazi]

Pushed some changes, it's now closer to the logic you proposed.

[jrom99]

Mentioning the issue for easier access: #136

[jrom99]

This may be a dumb question, and totally unrelated to the issue, but is there any reason in particular to use Class.prototype instead of JS class syntax?

[saadtazi]

This may be a dumb question, and totally unrelated to the issue, but is there any reason in particular to use Class.prototype instead of JS class syntax?

good question: firefox-profile package was created in october 2013 (more than 10 years ago 👴 ), at that time, class and const/let didn't exist in nodejs. class was introduced in nodejs 4.0.0 (in 2015).

I no longer use this package, so I didn't take the time to update the code (nor the test/CI tools)

[jrom99]

On second thought, I think process.env does not listen to snap or flatpak overrides for firefox.

In this case, I think the best behavior would be to assume that we can be dealing with a sandboxed or unsandboxed firefox install, where the normal home can still be a valid location for profile data, since both snap and flatpak seem to allow it.

So the code could be something like:

function locateLinuxDirectory() {
  userHomeDir = process.env.HOME;

  // look for a valid sandboxed profile dir
  homes = [
     path.join(userHomeDir, "snap/firefox/common"),
     path.join(userHomeDir, ".var/app/org.mozilla.firefox")
  ]
  for (home of homes) {
     dotDir = path.join(home, ".mozilla/firefox")
     xdgDir = path.join(home, ".config/mozilla/firefox")
     if (fs.existsSync(dotDir) {
       return dotDir
     } else if (fs.existsSync(xdgDir)) {
       return xdgDir
     }
  }

  // look in the next probable locations
  dotDir = path.join(userHomeDir, ".mozilla/firefox")
  xdgConfigDir = process.env.XDG_CONFIG_HOME || path.join(userHomedir, ".config")
  xdgDir = path.join(xdgConfigDir, "mozilla/firefox")
  return fs.existsSync(dotDir) ? dotDir : xdgDir;
}

[saadtazi]

sorry for the delay, I didn't have access to a computer... pushed some changes...

[jrom99]

I think the logic is still inverted for global installs. The dot dir should be preferred if it exists, but it should not be the default directory.

Also, the XDG config dir doesn't need a leading dot.

[jrom99]

Actually, the second corner case would actually mean that something is terribly wrong or Firefox is not installed, so maybe throwing an error would be better?

[saadtazi]

I am really sorry for the delay, got a new job last week, I didn't had time to finish this PR...

To prevent breaking changes (for now...), I added a warning if no linux folder is found, but it continues (no error thrown). I will publish a new version with current changes.