Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery migrate #873

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove jQuery migrate #873

wants to merge 5 commits into from

Conversation

onli
Copy link
Member

@onli onli commented Feb 17, 2025

Removes jQuery migrate and replaces the parts of the backend JS that does not work without it.

A followup to #687

@onli
Copy link
Member Author

onli commented Feb 17, 2025

Done in the backend as far as I can see. Edit: No, the tabs would be better when implemented with detail/summary instead. I'll test that out at least.

TODO: Test plugins and themes as in #686 (comment)

Core themes that use jQuery

  • clean-blog
  • next
  • default (I think, I'm not 100% sure)
  • 2k11, including in the admin interface
  • bootstrap4 (but that should work with jQuery 3.x since bootstrap bundles that)
  • timeline

The biggest potential issue I have seen here so far is a dependency on FitVids, which requires jQuery, in clean-blog, timeline and 2k11, which is a third-party script that hasn't been updated in a long time. Then there's of course our backend JS, which uses jQuery and also uses plugins that depend on jQuery.

^-- TODO: Check the FitVid part, I'm not aware of that dependency. I only checked clicking visiting entries with the themes.

It seems like no core plugin uses jQuery.

Additional plugins that require jQuery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant