Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3tr enhancements #700

Merged
merged 6 commits into from
Oct 12, 2023
Merged

s3tr enhancements #700

merged 6 commits into from
Oct 12, 2023

Conversation

irq0
Copy link
Member

@irq0 irq0 commented Sep 1, 2023

Collection of s3tr enhancements:

  • Collect prometheus metrics after test
  • Selectively enable lifecycle debugging mode (reduces logs)
  • Change "this tests shall pass" mode to "ok to fail"

Merge must be coordinated with CI change to aquarist-labs/ceph and merge of an excuse.csv file there

Fixes: https://github.com/aquarist-labs/s3gw/issues/665

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • CHANGELOG.md has been updated should there be relevant changes in this PR.

Marcel Lauhoff added 6 commits September 1, 2023 17:36
Enable lifecycle debugging (--rgw-lc-debug-interval 10) only on
lifecycle tests.

Removes LC debug noise from radosgw output of all other tests

Signed-off-by: Marcel Lauhoff <[email protected]>
Signed-off-by: Marcel Lauhoff <[email protected]>
Remove new-successes/new-failures commands.
Add new summary command that either prints stats or with a excuses.csv
compares the test results to an excuse file. This inverts the previous
logic where we had a file with test that must pass. We now have a list
with tests that are ok to fail plus URLs/excuses

Signed-off-by: Marcel Lauhoff <[email protected]>
@irq0 irq0 requested a review from m-ildefons September 1, 2023 15:41
@irq0 irq0 self-assigned this Sep 1, 2023
@irq0 irq0 added area/rgw-sfs RGW & SFS related area/CI Continuous Integration and removed area/rgw-sfs RGW & SFS related labels Sep 1, 2023
Copy link
Contributor

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jecluis
Copy link
Contributor

jecluis commented Oct 11, 2023

@irq0 is this good to go?

@irq0
Copy link
Member Author

irq0 commented Oct 12, 2023

@irq0 is this good to go?

Merge needs coordination with aquarist-labs/ceph#221 to not break CI on aquarist-labs/ceph

@jecluis
Copy link
Contributor

jecluis commented Oct 12, 2023

Okay. Both are approved now. Merge away.

@irq0 irq0 merged commit 69f0927 into s3gw-tech:main Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: s3 tests - switch build fail decision from "shall pass" list to "ok to fail" list
3 participants